Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files |
Infos |
Warnings |
Errors |
| 84 |
0 |
0 |
1463 |
Files
net/sf/navigator/displayer/AbstractMenuDisplayer.java
| Error |
Line |
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
29
|
|
|
Variable 'log' must be private and have accessor methods. |
29
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Variable 'name' must be private and have accessor methods. |
30
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Variable 'displayStrings' must be private and have accessor methods. |
31
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Variable 'out' must be private and have accessor methods. |
32
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Variable 'target' must be private and have accessor methods. |
33
|
|
|
Variable 'permissionsAdapter' must be private and have accessor methods. |
36
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Variable 'mapping' must be private and have accessor methods. |
37
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
|
Missing a Javadoc comment. |
41
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Missing a Javadoc comment. |
45
|
|
|
Parameter name should be final. |
45
|
|
|
'name' hides a field. |
45
|
|
|
Method 'getConfig' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
|
Missing a Javadoc comment. |
49
|
|
|
Method 'setConfig' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
|
Missing a Javadoc comment. |
59
|
|
|
Parameter config should be final. |
59
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
|
Missing a Javadoc comment. |
63
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
|
Parameter menu should be final. |
74
|
|
|
Expected @param tag for 'menu'. |
74
|
|
|
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
|
Missing a Javadoc comment. |
88
|
|
|
Parameter target should be final. |
88
|
|
|
'target' hides a field. |
88
|
|
|
Method 'getPermissionsAdapter' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
|
Method 'setPermissionsAdapter' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
|
Parameter permissionsAdapter should be final. |
104
|
|
|
'permissionsAdapter' hides a field. |
104
|
|
|
Line is longer than 80 characters. |
109
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
|
Parameter pageContext should be final. |
117
|
|
|
Parameter mapping should be final. |
117
|
|
|
'mapping' hides a field. |
117
|
|
|
Missing a Javadoc comment. |
122
|
|
|
Parameter menu should be final. |
122
|
|
|
Missing a Javadoc comment. |
125
|
|
|
Parameter pageContext should be final. |
125
|
|
|
'{' is not followed by whitespace. |
125
|
|
|
'}' is not preceded with whitespace. |
125
|
|
|
Method 'isAllowed' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
|
Parameter menu should be final. |
136
|
net/sf/navigator/displayer/CSSListMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
16
|
|
|
Missing a Javadoc comment. |
16
|
|
|
Parameter menu should be final. |
16
|
|
|
Avoid inline conditionals. |
19
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
25
|
|
|
Missing a Javadoc comment. |
25
|
|
|
Parameter menu should be final. |
25
|
|
|
Parameter level should be final. |
25
|
|
|
Line is longer than 80 characters. |
28
|
|
|
'{' is not preceded with whitespace. |
35
|
|
|
Line is longer than 80 characters. |
43
|
|
|
Line is longer than 80 characters. |
61
|
|
|
Avoid inline conditionals. |
61
|
|
|
Line is longer than 80 characters. |
62
|
|
|
Line is longer than 80 characters. |
65
|
|
|
Line is longer than 80 characters. |
66
|
|
|
Line is longer than 80 characters. |
67
|
|
|
Line is longer than 80 characters. |
68
|
|
|
Line is longer than 80 characters. |
81
|
|
|
Line is longer than 80 characters. |
83
|
|
|
Line is longer than 80 characters. |
87
|
|
|
Line is longer than 80 characters. |
89
|
|
|
Missing a Javadoc comment. |
94
|
|
|
Parameter menu should be final. |
94
|
net/sf/navigator/displayer/CoolMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
25
|
|
|
Line is longer than 80 characters. |
26
|
|
|
Line is longer than 80 characters. |
29
|
|
|
Line is longer than 80 characters. |
30
|
|
|
Line is longer than 80 characters. |
31
|
|
|
Line is longer than 80 characters. |
34
|
|
|
Line is longer than 80 characters. |
35
|
|
|
Line is longer than 80 characters. |
36
|
|
|
Line is longer than 80 characters. |
37
|
|
|
Line is longer than 80 characters. |
38
|
|
|
Line is longer than 80 characters. |
39
|
|
|
Line is longer than 80 characters. |
41
|
|
|
Line is longer than 80 characters. |
46
|
|
|
Line is longer than 80 characters. |
51
|
|
|
'+' should be on a new line. |
51
|
|
|
Missing a Javadoc comment. |
53
|
|
|
Missing a Javadoc comment. |
55
|
|
|
Missing a Javadoc comment. |
56
|
|
|
Missing a Javadoc comment. |
58
|
|
|
Missing a Javadoc comment. |
59
|
|
|
Missing a Javadoc comment. |
60
|
|
|
Missing a Javadoc comment. |
61
|
|
|
Missing a Javadoc comment. |
62
|
|
|
Missing a Javadoc comment. |
63
|
|
|
Missing a Javadoc comment. |
64
|
|
|
Missing a Javadoc comment. |
65
|
|
|
Missing a Javadoc comment. |
66
|
|
|
Missing a Javadoc comment. |
67
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
|
Missing a Javadoc comment. |
71
|
|
|
Parameter context should be final. |
71
|
|
|
Parameter mapping should be final. |
71
|
|
|
Must have at least one statement. |
76
|
|
|
'{' is not followed by whitespace. |
76
|
|
|
'}' is not preceded with whitespace. |
76
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
|
Parameter menu should be final. |
83
|
|
|
Expected @param tag for 'menu'. |
83
|
|
|
Expected @throws tag for 'JspException'. |
83
|
|
|
Expected @throws tag for 'IOException'. |
83
|
|
|
First sentence should end with a period. |
89
|
|
|
Method 'end' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
|
Parameter context should be final. |
93
|
|
|
Expected @param tag for 'context'. |
93
|
|
|
Must have at least one statement. |
97
|
|
|
'{' is not followed by whitespace. |
97
|
|
|
'}' is not preceded with whitespace. |
97
|
|
|
Method 'buildMenuString' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
|
Missing a Javadoc comment. |
100
|
|
|
Parameter menu should be final. |
100
|
|
|
Parameter sb should be final. |
100
|
|
|
Parameter allowed should be final. |
101
|
|
|
Avoid inline conditionals. |
103
|
|
|
Avoid inline conditionals. |
105
|
|
|
Avoid inline conditionals. |
113
|
|
|
Method 'getArgs' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
|
Missing a Javadoc comment. |
118
|
|
|
Parameter menu should be final. |
118
|
|
|
Parameter allowed should be final. |
118
|
|
|
'10' is a magic number. |
119
|
|
|
'3' is a magic number. |
123
|
|
|
Avoid inline conditionals. |
124
|
|
|
Avoid inline conditionals. |
125
|
|
|
'4' is a magic number. |
126
|
|
|
'5' is a magic number. |
127
|
|
|
'6' is a magic number. |
128
|
|
|
'7' is a magic number. |
129
|
|
|
Avoid inline conditionals. |
129
|
|
|
'8' is a magic number. |
130
|
|
|
Avoid inline conditionals. |
130
|
|
|
'9' is a magic number. |
131
|
|
|
Avoid inline conditionals. |
131
|
|
|
Expected an @return tag. |
142
|
|
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
|
Parameter menu should be final. |
142
|
|
|
Expected @param tag for 'menu'. |
142
|
|
|
Method 'getParentName' is not designed for extension - needs to be abstract, final or empty. |
159
|
|
|
Missing a Javadoc comment. |
159
|
|
|
Parameter menu should be final. |
159
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
171
|
|
|
Missing a Javadoc comment. |
171
|
|
|
Parameter menu should be final. |
171
|
net/sf/navigator/displayer/CoolMenuDisplayer4.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
25
|
|
|
Line is longer than 80 characters. |
26
|
|
|
Line is longer than 80 characters. |
29
|
|
|
Line is longer than 80 characters. |
30
|
|
|
Line is longer than 80 characters. |
31
|
|
|
Line is longer than 80 characters. |
38
|
|
|
Line is longer than 80 characters. |
39
|
|
|
Line is longer than 80 characters. |
40
|
|
|
Line is longer than 80 characters. |
42
|
|
|
Line has trailing spaces. |
46
|
|
|
Line has trailing spaces. |
47
|
|
|
Line is longer than 80 characters. |
47
|
|
|
Line has trailing spaces. |
51
|
|
|
Line is longer than 80 characters. |
51
|
|
|
'+' should be on a new line. |
55
|
|
|
Missing a Javadoc comment. |
57
|
|
|
Missing a Javadoc comment. |
58
|
|
|
Missing a Javadoc comment. |
60
|
|
|
Missing a Javadoc comment. |
61
|
|
|
Missing a Javadoc comment. |
62
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
|
Missing a Javadoc comment. |
66
|
|
|
Parameter pageContext should be final. |
66
|
|
|
Parameter mapping should be final. |
66
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
|
Parameter menu should be final. |
81
|
|
|
Expected @param tag for 'menu'. |
81
|
|
|
Expected @throws tag for 'JspException'. |
81
|
|
|
Expected @throws tag for 'IOException'. |
81
|
|
|
First sentence should end with a period. |
87
|
|
|
Method 'end' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
|
Parameter context should be final. |
91
|
|
|
Expected @param tag for 'context'. |
91
|
|
|
Line is longer than 80 characters. |
102
|
|
|
Method 'buildMenuString' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
|
Missing a Javadoc comment. |
102
|
|
|
Parameter menu should be final. |
102
|
|
|
Parameter sb should be final. |
102
|
|
|
Parameter allowed should be final. |
102
|
|
|
Line is longer than 80 characters. |
104
|
|
|
Method 'getArgs' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
|
Missing a Javadoc comment. |
116
|
|
|
Parameter menu should be final. |
116
|
|
|
'10' is a magic number. |
117
|
|
|
Avoid inline conditionals. |
122
|
|
|
'+' should be on a new line. |
122
|
|
|
'3' is a magic number. |
124
|
|
|
Avoid inline conditionals. |
124
|
|
|
'4' is a magic number. |
125
|
|
|
'5' is a magic number. |
126
|
|
|
Avoid inline conditionals. |
126
|
|
|
'6' is a magic number. |
127
|
|
|
Avoid inline conditionals. |
127
|
|
|
'7' is a magic number. |
128
|
|
|
Avoid inline conditionals. |
128
|
|
|
'8' is a magic number. |
129
|
|
|
Avoid inline conditionals. |
130
|
|
|
'9' is a magic number. |
131
|
|
|
Avoid inline conditionals. |
131
|
|
|
Method 'getParentName' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
|
Missing a Javadoc comment. |
140
|
|
|
Parameter menu should be final. |
140
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
|
Missing a Javadoc comment. |
152
|
|
|
Parameter menu should be final. |
152
|
|
|
Missing a Javadoc comment. |
162
|
|
|
Avoid inline conditionals. |
163
|
net/sf/navigator/displayer/DropDownMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
24
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Parameter pageContext should be final. |
24
|
|
|
Parameter mapping should be final. |
24
|
|
|
Line has trailing spaces. |
31
|
|
|
Must have at least one statement. |
43
|
|
|
'{' is not followed by whitespace. |
43
|
|
|
'}' is not preceded with whitespace. |
43
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
|
Missing a Javadoc comment. |
46
|
|
|
Parameter menu should be final. |
46
|
|
|
'+' should be on a new line. |
65
|
|
|
'+' should be on a new line. |
76
|
|
|
Missing a Javadoc comment. |
87
|
|
|
Parameter menu should be final. |
87
|
|
|
Parameter sb should be final. |
87
|
|
|
Line is longer than 80 characters. |
118
|
|
|
'+' should be on a new line. |
118
|
|
|
Line is longer than 80 characters. |
130
|
|
|
'+' should be on a new line. |
130
|
net/sf/navigator/displayer/ListMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
26
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Parameter pageContext should be final. |
26
|
|
|
Parameter mapping should be final. |
26
|
|
|
Avoid inline conditionals. |
32
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Parameter menu should be final. |
38
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
|
Missing a Javadoc comment. |
46
|
|
|
Parameter menu should be final. |
46
|
|
|
Parameter level should be final. |
46
|
|
|
Line is longer than 80 characters. |
52
|
|
|
'1000' is a magic number. |
54
|
|
|
'*' is not preceded with whitespace. |
54
|
|
|
'*' is not followed by whitespace. |
54
|
|
|
')' is preceded with whitespace. |
63
|
|
|
'{' is not preceded with whitespace. |
63
|
|
|
Line has trailing spaces. |
73
|
|
|
Line is longer than 80 characters. |
82
|
|
|
Line is longer than 80 characters. |
85
|
|
|
Line is longer than 80 characters. |
86
|
|
|
Line is longer than 80 characters. |
87
|
|
|
Line is longer than 80 characters. |
88
|
|
|
Line is longer than 80 characters. |
101
|
|
|
Line is longer than 80 characters. |
103
|
|
|
Line is longer than 80 characters. |
107
|
|
|
Line is longer than 80 characters. |
109
|
|
|
First sentence should end with a period. |
114
|
|
|
Method 'end' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
|
Parameter context should be final. |
118
|
|
|
Method 'getExtra' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
|
Missing a Javadoc comment. |
126
|
|
|
Parameter menu should be final. |
126
|
|
|
Line is longer than 80 characters. |
135
|
|
|
Line is longer than 80 characters. |
138
|
|
|
Avoid inline conditionals. |
143
|
net/sf/navigator/displayer/LocalDirective.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line has trailing spaces. |
96
|
|
|
'{' should be on the previous line. |
99
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
|
Missing a Javadoc comment. |
100
|
|
|
'{' should be on the previous line. |
101
|
|
|
Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
|
Missing a Javadoc comment. |
105
|
|
|
'{' should be on the previous line. |
106
|
|
|
Method 'render' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
|
Missing a Javadoc comment. |
110
|
|
|
Parameter context should be final. |
110
|
|
|
Parameter writer should be final. |
111
|
|
|
Parameter node should be final. |
111
|
|
|
Line is longer than 80 characters. |
112
|
|
|
'{' should be on the previous line. |
114
|
|
|
'=' is not preceded with whitespace. |
123
|
|
|
'=' is not followed by whitespace. |
123
|
|
|
'{' should be on the previous line. |
124
|
|
|
'{' should be on the previous line. |
132
|
|
|
'}' should be on the same line. |
135
|
|
|
'{' should be on the previous line. |
137
|
|
|
'{' should be on the previous line. |
141
|
|
|
'}' should be on the same line. |
143
|
|
|
'{' should be on the previous line. |
145
|
|
|
'while' is not followed by whitespace. |
153
|
|
|
'{' should be on the previous line. |
154
|
net/sf/navigator/displayer/MenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Redundant 'public' modifier. |
24
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Redundant 'public' modifier. |
26
|
|
|
Name '_SELF' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
26
|
|
|
Missing a Javadoc comment. |
27
|
|
|
Redundant 'public' modifier. |
27
|
|
|
Missing a Javadoc comment. |
28
|
|
|
Redundant 'public' modifier. |
28
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Redundant 'public' modifier. |
32
|
|
|
Redundant 'public' modifier. |
38
|
|
|
First sentence should end with a period. |
40
|
|
|
Redundant 'public' modifier. |
44
|
|
|
Redundant 'public' modifier. |
52
|
|
|
Redundant 'public' modifier. |
60
|
|
|
Redundant 'public' modifier. |
67
|
|
|
Redundant 'public' modifier. |
72
|
|
|
Line is longer than 80 characters. |
75
|
|
|
Redundant 'public' modifier. |
83
|
|
|
Line is longer than 80 characters. |
86
|
|
|
Redundant 'public' modifier. |
92
|
|
|
Redundant 'public' modifier. |
97
|
|
|
Redundant 'public' modifier. |
102
|
net/sf/navigator/displayer/MenuDisplayerMapping.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
|
Parameter name should be final. |
40
|
|
|
'name' hides a field. |
40
|
|
|
Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
|
Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
|
Parameter type should be final. |
54
|
|
|
'type' hides a field. |
54
|
|
|
Method 'getConfig' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
|
Method 'setConfig' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
|
Parameter config should be final. |
68
|
|
|
'config' hides a field. |
68
|
net/sf/navigator/displayer/MessageResourcesMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
25
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Variable 'log' must be private and have accessor methods. |
26
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Variable 'messages' must be private and have accessor methods. |
30
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Variable 'locale' must be private and have accessor methods. |
31
|
|
|
Method 'getLocale' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
|
Missing a Javadoc comment. |
35
|
|
|
Method 'setLocale' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
|
Missing a Javadoc comment. |
39
|
|
|
Parameter locale should be final. |
39
|
|
|
'locale' hides a field. |
39
|
|
|
Method 'getMessageResources' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
|
Missing a Javadoc comment. |
43
|
|
|
Method 'setMessageResources' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
|
Missing a Javadoc comment. |
47
|
|
|
Parameter messages should be final. |
47
|
|
|
'messages' hides a field. |
47
|
|
|
Line has trailing spaces. |
54
|
|
|
Expected an @return tag. |
57
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
|
Parameter key should be final. |
57
|
|
|
Line is longer than 80 characters. |
72
|
|
|
Line is longer than 80 characters. |
74
|
|
|
Line is longer than 80 characters. |
75
|
|
|
Line is longer than 80 characters. |
79
|
|
|
Expected an @return tag. |
105
|
|
|
Method 'getMenuTarget' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
|
Parameter menu should be final. |
105
|
|
|
Expected @param tag for 'menu'. |
105
|
|
|
Expected an @return tag. |
127
|
|
|
Method 'getMenuToolTip' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
|
Parameter menu should be final. |
127
|
|
|
Expected @param tag for 'menu'. |
127
|
|
|
Method 'getMenuOnClick' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
|
Missing a Javadoc comment. |
139
|
|
|
Parameter menu should be final. |
139
|
|
|
Missing a Javadoc comment. |
146
|
|
|
Parameter menu should be final. |
146
|
net/sf/navigator/displayer/SimpleMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
23
|
|
|
Name 'nbsp' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
27
|
|
|
Missing a Javadoc comment. |
27
|
|
|
Parameter pageContext should be final. |
27
|
|
|
Parameter mapping should be final. |
27
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Parameter menu should be final. |
37
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Missing a Javadoc comment. |
45
|
|
|
Parameter menu should be final. |
45
|
|
|
Parameter level should be final. |
45
|
|
|
'+' should be on a new line. |
51
|
|
|
'+' should be on a new line. |
52
|
|
|
Line is longer than 80 characters. |
66
|
|
|
'+' should be on a new line. |
66
|
|
|
'+' should be on a new line. |
75
|
|
|
Method 'getSpace' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
|
Missing a Javadoc comment. |
80
|
|
|
Parameter length should be final. |
80
|
|
|
Method 'getImage' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
|
Missing a Javadoc comment. |
90
|
|
|
Parameter menu should be final. |
90
|
net/sf/navigator/displayer/TabbedMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
18
|
|
|
Missing a Javadoc comment. |
18
|
|
|
Parameter menu should be final. |
18
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
24
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Parameter menu should be final. |
24
|
|
|
Parameter level should be final. |
24
|
|
|
'+' should be on a new line. |
38
|
|
|
Line is longer than 80 characters. |
39
|
|
|
Line is longer than 80 characters. |
60
|
net/sf/navigator/displayer/VelocityMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Using the '.*' form of import should be avoided - java.util.*. |
26
|
|
|
Line is longer than 80 characters. |
33
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Missing a Javadoc comment. |
35
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Parameter context should be final. |
37
|
|
|
Line is longer than 80 characters. |
38
|
|
|
Line is longer than 80 characters. |
46
|
|
|
Line is longer than 80 characters. |
51
|
|
|
Line is longer than 80 characters. |
52
|
|
|
Line is longer than 80 characters. |
63
|
|
|
Line is longer than 80 characters. |
68
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
|
Missing a Javadoc comment. |
80
|
|
|
Parameter pageContext should be final. |
80
|
|
|
'pageContext' hides a field. |
80
|
|
|
Parameter mapping should be final. |
80
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
|
Missing a Javadoc comment. |
85
|
|
|
Parameter menu should be final. |
85
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
|
Missing a Javadoc comment. |
91
|
|
|
Parameter menu should be final. |
91
|
|
|
Line is longer than 80 characters. |
93
|
|
|
Line is longer than 80 characters. |
100
|
|
|
Method 'end' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
|
Missing a Javadoc comment. |
164
|
|
|
Parameter context should be final. |
164
|
net/sf/navigator/displayer/XtreeMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Redundant import from the same package - net.sf.navigator.displayer.MenuDisplayerMapping. |
9
|
|
|
Redundant import from the same package - net.sf.navigator.displayer.MessageResourcesMenuDisplayer. |
10
|
|
|
Unused import - org.apache.commons.lang.StringUtils. |
12
|
|
|
First sentence should end with a period. |
14
|
|
|
Line has trailing spaces. |
16
|
|
|
Line is longer than 80 characters. |
22
|
|
|
Line is longer than 80 characters. |
23
|
|
|
Line has trailing spaces. |
24
|
|
|
Line is longer than 80 characters. |
26
|
|
|
Line is longer than 80 characters. |
30
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Line is longer than 80 characters. |
31
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Line is longer than 80 characters. |
32
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Line is longer than 80 characters. |
33
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Line is longer than 80 characters. |
34
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Missing a Javadoc comment. |
35
|
|
|
Line has trailing spaces. |
36
|
|
|
Line has trailing spaces. |
37
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Line has trailing spaces. |
38
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Missing a Javadoc comment. |
39
|
|
|
Line is longer than 80 characters. |
40
|
|
|
Missing a Javadoc comment. |
40
|
|
|
Missing a Javadoc comment. |
41
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Missing a Javadoc comment. |
45
|
|
|
Parameter context should be final. |
45
|
|
|
Parameter mapping should be final. |
45
|
|
|
Must have at least one statement. |
50
|
|
|
Method 'display' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
|
Missing a Javadoc comment. |
54
|
|
|
Parameter menu should be final. |
54
|
|
|
Method 'end' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
|
Missing a Javadoc comment. |
61
|
|
|
Parameter context should be final. |
61
|
|
|
Must have at least one statement. |
64
|
|
|
Line is longer than 80 characters. |
68
|
|
|
Method 'buildMenuString' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
|
Missing a Javadoc comment. |
68
|
|
|
Parameter menu should be final. |
68
|
|
|
Parameter sb should be final. |
68
|
|
|
Parameter allowed should be final. |
68
|
|
|
'3' is a magic number. |
74
|
|
|
'3' is a magic number. |
74
|
|
|
Line is longer than 80 characters. |
75
|
|
|
Line has trailing spaces. |
76
|
|
|
Line is longer than 80 characters. |
76
|
|
|
Line is longer than 80 characters. |
78
|
|
|
Line has trailing spaces. |
79
|
|
|
Line is longer than 80 characters. |
79
|
|
|
Line has trailing spaces. |
81
|
|
|
Line is longer than 80 characters. |
86
|
|
|
Avoid inline conditionals. |
86
|
|
|
Method 'getArgs' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
|
Missing a Javadoc comment. |
92
|
|
|
Parameter menu should be final. |
92
|
|
|
'4' is a magic number. |
93
|
|
|
'3' is a magic number. |
97
|
|
|
Avoid inline conditionals. |
97
|
|
|
Method 'getParentName' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
|
Missing a Javadoc comment. |
102
|
|
|
Parameter menu should be final. |
102
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
|
Missing a Javadoc comment. |
114
|
|
|
Parameter menu should be final. |
114
|
net/sf/navigator/displayer/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
net/sf/navigator/example/DisplaySourceServlet.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
First sentence should end with a period. |
15
|
|
|
Line is longer than 80 characters. |
25
|
|
|
Parameter request should be final. |
27
|
|
|
Parameter response should be final. |
28
|
|
|
Line has trailing spaces. |
37
|
|
|
Line is longer than 80 characters. |
49
|
|
|
'+' should be on a new line. |
49
|
|
|
Line is longer than 80 characters. |
51
|
|
|
Line is longer than 80 characters. |
56
|
net/sf/navigator/example/PermissionsFormMenuDisplayer.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Name 'inputMessage' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
24
|
|
|
Missing a Javadoc comment. |
27
|
|
|
Name 'itemMessage' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
27
|
|
|
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Parameter menu should be final. |
33
|
|
|
Parameter level should be final. |
33
|
|
|
'+' should be on a new line. |
40
|
|
|
'+' should be on a new line. |
41
|
|
|
Line is longer than 80 characters. |
48
|
|
|
Missing a Javadoc comment. |
56
|
|
|
Parameter menu should be final. |
56
|
|
|
Parameter space should be final. |
56
|
|
|
Missing a Javadoc comment. |
63
|
|
|
Parameter menu should be final. |
63
|
|
|
'{' is followed by whitespace. |
64
|
net/sf/navigator/example/SetPermissionsAction.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Unused @param tag for 'actionForm'. |
43
|
|
|
Expected an @return tag. |
49
|
|
|
Parameter mapping should be final. |
49
|
|
|
Parameter form should be final. |
49
|
|
|
Expected @param tag for 'form'. |
49
|
|
|
Parameter request should be final. |
50
|
|
|
Parameter response should be final. |
50
|
net/sf/navigator/example/SimplePermissionsAdapter.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Missing a Javadoc comment. |
21
|
|
|
First sentence should end with a period. |
25
|
|
|
Parameter theMenuNames should be final. |
28
|
|
|
Expected @param tag for 'theMenuNames'. |
28
|
|
|
Method 'isAllowed' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Parameter menu should be final. |
45
|
|
|
Expected @param tag for 'menu'. |
45
|
net/sf/navigator/example/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
net/sf/navigator/menu/Component.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Missing a Javadoc comment. |
8
|
|
|
Missing a Javadoc comment. |
9
|
net/sf/navigator/menu/MenuBase.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Variable 'action' must be private and have accessor methods. |
14
|
|
|
First sentence should end with a period. |
16
|
|
|
Line is longer than 80 characters. |
16
|
|
|
Variable 'align' must be private and have accessor methods. |
17
|
|
|
Line has trailing spaces. |
18
|
|
|
Variable 'altImage' must be private and have accessor methods. |
20
|
|
|
Variable 'description' must be private and have accessor methods. |
23
|
|
|
Variable 'forward' must be private and have accessor methods. |
26
|
|
|
Variable 'height' must be private and have accessor methods. |
29
|
|
|
Variable 'image' must be private and have accessor methods. |
32
|
|
|
Variable 'location' must be private and have accessor methods. |
35
|
|
|
Variable 'name' must be private and have accessor methods. |
38
|
|
|
Variable 'onclick' must be private and have accessor methods. |
41
|
|
|
Variable 'ondblclick' must be private and have accessor methods. |
44
|
|
|
Variable 'onmouseout' must be private and have accessor methods. |
47
|
|
|
Variable 'onmouseover' must be private and have accessor methods. |
50
|
|
|
Variable 'page' must be private and have accessor methods. |
53
|
|
|
Variable 'roles' must be private and have accessor methods. |
56
|
|
|
Variable 'target' must be private and have accessor methods. |
59
|
|
|
Variable 'title' must be private and have accessor methods. |
62
|
|
|
Variable 'toolTip' must be private and have accessor methods. |
65
|
|
|
Variable 'width' must be private and have accessor methods. |
68
|
|
|
First sentence should end with a period. |
70
|
|
|
Line has trailing spaces. |
72
|
|
|
First sentence should end with a period. |
73
|
|
|
Variable 'onContextMenu' must be private and have accessor methods. |
74
|
|
|
Line is longer than 80 characters. |
77
|
|
|
Line is longer than 80 characters. |
79
|
|
|
Variable 'module' must be private and have accessor methods. |
81
|
|
|
Method 'setAction' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
|
Parameter action should be final. |
89
|
|
|
'action' hides a field. |
89
|
|
|
Method 'getAction' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
|
Method 'getAlign' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
|
Line has trailing spaces. |
108
|
|
|
Method 'setAlign' is not designed for extension - needs to be abstract, final or empty. |
113
|
|
|
Parameter align should be final. |
113
|
|
|
'align' hides a field. |
113
|
|
|
Line has trailing spaces. |
116
|
|
|
Method 'setAltImage' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
|
Parameter altImage should be final. |
120
|
|
|
'altImage' hides a field. |
120
|
|
|
Method 'getAltImage' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
|
Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
|
Parameter description should be final. |
134
|
|
|
'description' hides a field. |
134
|
|
|
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
|
Method 'setForward' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
|
Parameter forward should be final. |
149
|
|
|
'forward' hides a field. |
149
|
|
|
Method 'getForward' is not designed for extension - needs to be abstract, final or empty. |
156
|
|
|
Method 'setHeight' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
|
Parameter height should be final. |
163
|
|
|
'height' hides a field. |
163
|
|
|
Expected @param tag for 'height'. |
163
|
|
|
Expected an @return tag. |
170
|
|
|
Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. |
170
|
|
|
Method 'setImage' is not designed for extension - needs to be abstract, final or empty. |
177
|
|
|
Parameter image should be final. |
177
|
|
|
'image' hides a field. |
177
|
|
|
Method 'getImage' is not designed for extension - needs to be abstract, final or empty. |
184
|
|
|
Method 'setLocation' is not designed for extension - needs to be abstract, final or empty. |
191
|
|
|
Parameter location should be final. |
191
|
|
|
'location' hides a field. |
191
|
|
|
Method 'getLocation' is not designed for extension - needs to be abstract, final or empty. |
198
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
|
Parameter name should be final. |
205
|
|
|
'name' hides a field. |
205
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
|
Method 'setOnclick' is not designed for extension - needs to be abstract, final or empty. |
219
|
|
|
Parameter onclick should be final. |
219
|
|
|
'onclick' hides a field. |
219
|
|
|
Method 'getOnclick' is not designed for extension - needs to be abstract, final or empty. |
226
|
|
|
Method 'setOnmouseout' is not designed for extension - needs to be abstract, final or empty. |
233
|
|
|
Parameter onmouseout should be final. |
233
|
|
|
'onmouseout' hides a field. |
233
|
|
|
Method 'getOnmouseout' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
|
Method 'setOnmouseover' is not designed for extension - needs to be abstract, final or empty. |
247
|
|
|
Parameter onmouseover should be final. |
247
|
|
|
'onmouseover' hides a field. |
247
|
|
|
Method 'getOnmouseover' is not designed for extension - needs to be abstract, final or empty. |
254
|
|
|
Method 'setPage' is not designed for extension - needs to be abstract, final or empty. |
262
|
|
|
Parameter page should be final. |
262
|
|
|
'page' hides a field. |
262
|
|
|
Method 'getPage' is not designed for extension - needs to be abstract, final or empty. |
270
|
|
|
Method 'setRoles' is not designed for extension - needs to be abstract, final or empty. |
278
|
|
|
Parameter roles should be final. |
278
|
|
|
'roles' hides a field. |
278
|
|
|
Method 'getRoles' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
|
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. |
293
|
|
|
Parameter target should be final. |
293
|
|
|
'target' hides a field. |
293
|
|
|
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. |
300
|
|
|
Method 'setTitle' is not designed for extension - needs to be abstract, final or empty. |
307
|
|
|
Parameter title should be final. |
307
|
|
|
'title' hides a field. |
307
|
|
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. |
314
|
|
|
Method 'setToolTip' is not designed for extension - needs to be abstract, final or empty. |
321
|
|
|
Parameter toolTip should be final. |
321
|
|
|
'toolTip' hides a field. |
321
|
|
|
Method 'getToolTip' is not designed for extension - needs to be abstract, final or empty. |
328
|
|
|
Method 'setUrl' is not designed for extension - needs to be abstract, final or empty. |
335
|
|
|
Parameter url should be final. |
335
|
|
|
'url' hides a field. |
335
|
|
|
Expected @param tag for 'url'. |
335
|
|
|
Expected an @return tag. |
342
|
|
|
Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
342
|
|
|
Method 'setWidth' is not designed for extension - needs to be abstract, final or empty. |
350
|
|
|
Parameter width should be final. |
350
|
|
|
'width' hides a field. |
350
|
|
|
Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. |
357
|
|
|
Expected an @return tag. |
363
|
|
|
Method 'getOnContextMenu' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
|
Method 'setOnContextMenu' is not designed for extension - needs to be abstract, final or empty. |
370
|
|
|
Parameter string should be final. |
370
|
|
|
Expected @param tag for 'string'. |
370
|
|
|
Method 'getOndblclick' is not designed for extension - needs to be abstract, final or empty. |
378
|
|
|
Method 'setOndblclick' is not designed for extension - needs to be abstract, final or empty. |
386
|
|
|
Parameter ondblclick should be final. |
386
|
|
|
'ondblclick' hides a field. |
386
|
|
|
Method 'getModule' is not designed for extension - needs to be abstract, final or empty. |
390
|
|
|
Missing a Javadoc comment. |
390
|
|
|
Method 'setModule' is not designed for extension - needs to be abstract, final or empty. |
394
|
|
|
Missing a Javadoc comment. |
394
|
|
|
Parameter module should be final. |
394
|
|
|
'module' hides a field. |
394
|
net/sf/navigator/menu/MenuComponent.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Name '_menuComponent' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
26
|
|
|
Variable '_menuComponent' must be private and have accessor methods. |
26
|
|
|
Line is longer than 80 characters. |
30
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Variable 'menuComponents' must be private and have accessor methods. |
30
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Variable 'parentMenu' must be private and have accessor methods. |
31
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Method 'addMenuComponent' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Parameter menuComponent should be final. |
37
|
|
|
Line is longer than 80 characters. |
38
|
|
|
Method 'getMenuComponents' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
|
Missing a Javadoc comment. |
48
|
|
|
Method 'setMenuComponents' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
|
Missing a Javadoc comment. |
52
|
|
|
Parameter menuComponents should be final. |
52
|
|
|
'menuComponents' hides a field. |
52
|
|
|
Method 'setParent' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
|
Missing a Javadoc comment. |
59
|
|
|
Parameter parentMenu should be final. |
59
|
|
|
'parentMenu' hides a field. |
59
|
|
|
Method 'getParent' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
|
Missing a Javadoc comment. |
69
|
|
|
First sentence should end with a period. |
73
|
|
|
Method 'getComponents' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
|
First sentence should end with a period. |
81
|
|
|
Expected an @return tag. |
86
|
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
86
|
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
|
Parameter o should be final. |
86
|
|
|
'&&' should be on a new line. |
92
|
|
|
'&&' should be on a new line. |
93
|
|
|
'&&' should be on a new line. |
94
|
|
|
'&&' should be on a new line. |
95
|
|
|
'&&' should be on a new line. |
96
|
|
|
'&&' should be on a new line. |
97
|
|
|
'&&' should be on a new line. |
98
|
|
|
'&&' should be on a new line. |
99
|
|
|
'&&' should be on a new line. |
100
|
|
|
'&&' should be on a new line. |
101
|
|
|
'&&' should be on a new line. |
102
|
|
|
'&&' should be on a new line. |
103
|
|
|
'&&' should be on a new line. |
104
|
|
|
'&&' should be on a new line. |
105
|
|
|
'&&' should be on a new line. |
106
|
|
|
'&&' should be on a new line. |
107
|
|
|
'&&' should be on a new line. |
108
|
|
|
'&&' should be on a new line. |
109
|
|
|
'&&' should be on a new line. |
110
|
|
|
'&&' should be on a new line. |
111
|
|
|
First sentence should end with a period. |
115
|
|
|
Method 'getMenuDepth' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
|
Missing a Javadoc comment. |
124
|
|
|
Parameter menu should be final. |
124
|
|
|
Parameter currentDepth should be final. |
124
|
|
|
'if' construct must use '{}'s. |
131
|
|
|
Method 'isLast' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
|
Method 'setLast' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
|
Parameter last should be final. |
153
|
|
|
'last' hides a field. |
153
|
|
|
First sentence should end with a period. |
157
|
|
|
Method 'removeChildren' is not designed for extension - needs to be abstract, final or empty. |
160
|
|
|
Line is longer than 80 characters. |
161
|
|
|
Method 'getBreadCrumb' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
|
Missing a Javadoc comment. |
168
|
|
|
First sentence should end with a period. |
172
|
|
|
Method 'setBreadCrumb' is not designed for extension - needs to be abstract, final or empty. |
177
|
|
|
Parameter delimiter should be final. |
177
|
|
|
Missing a Javadoc comment. |
188
|
|
|
Parameter delimiter should be final. |
188
|
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
|
Missing a Javadoc comment. |
196
|
net/sf/navigator/menu/MenuContextListener.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Extra HTML tag found: </p> |
15
|
|
|
Line is longer than 80 characters. |
24
|
|
|
Line has trailing spaces. |
27
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Missing a Javadoc comment. |
32
|
|
|
First sentence should end with a period. |
34
|
|
|
Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
|
Parameter sce should be final. |
40
|
|
|
Expected @param tag for 'sce'. |
40
|
|
|
Line has trailing spaces. |
46
|
|
|
Line has trailing spaces. |
48
|
|
|
Line has trailing spaces. |
56
|
|
|
Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
|
Missing a Javadoc comment. |
73
|
|
|
Parameter sce should be final. |
73
|
|
|
Line is longer than 80 characters. |
78
|
net/sf/navigator/menu/MenuLoader.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Line has trailing spaces. |
12
|
|
|
Extra HTML tag found: </p> |
14
|
|
|
Line has trailing spaces. |
22
|
|
|
Line has trailing spaces. |
24
|
|
|
Missing a Javadoc comment. |
28
|
|
|
First sentence should end with a period. |
30
|
|
|
First sentence should end with a period. |
33
|
|
|
Method 'setMenuConfig' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
|
Parameter menuConfig should be final. |
37
|
|
|
'menuConfig' hides a field. |
37
|
|
|
Line is longer than 80 characters. |
43
|
|
|
Method 'initApplicationContext' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Redundant throws: 'ApplicationContextException' is unchecked exception. |
45
|
|
|
Line is longer than 80 characters. |
57
|
|
|
Line is longer than 80 characters. |
63
|
|
|
'+' should be on a new line. |
63
|
|
|
Line is longer than 80 characters. |
67
|
net/sf/navigator/menu/MenuPlugIn.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Method 'getMenuConfig' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Method 'setMenuConfig' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
|
Missing a Javadoc comment. |
42
|
|
|
Parameter menuConfig should be final. |
42
|
|
|
'menuConfig' hides a field. |
42
|
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
|
Missing a Javadoc comment. |
46
|
|
|
Parameter servlet should be final. |
46
|
|
|
'servlet' hides a field. |
46
|
|
|
Parameter config should be final. |
46
|
|
|
Line is longer than 80 characters. |
59
|
|
|
'+' should be on a new line. |
65
|
|
|
Method 'destroy' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
|
Missing a Javadoc comment. |
70
|
|
|
Line is longer than 80 characters. |
72
|
net/sf/navigator/menu/MenuRepository.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Using the '.*' form of import should be avoided - java.util.*. |
20
|
|
|
Line is longer than 80 characters. |
30
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Missing a Javadoc comment. |
31
|
|
|
Missing a Javadoc comment. |
35
|
|
|
Variable 'config' must be private and have accessor methods. |
35
|
|
|
Missing a Javadoc comment. |
36
|
|
|
Variable 'name' must be private and have accessor methods. |
36
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Variable 'servletContext' must be private and have accessor methods. |
37
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Variable 'menus' must be private and have accessor methods. |
38
|
|
|
Missing a Javadoc comment. |
39
|
|
|
Variable 'displayers' must be private and have accessor methods. |
39
|
|
|
Missing a Javadoc comment. |
40
|
|
|
Variable 'templates' must be private and have accessor methods. |
40
|
|
|
Missing a Javadoc comment. |
41
|
|
|
Method 'getMenuNames' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
|
Missing a Javadoc comment. |
44
|
|
|
Expected an @return tag. |
52
|
|
|
Method 'getTopMenus' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
|
'name' hides a field. |
60
|
|
|
Method 'getMenu' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
|
Missing a Javadoc comment. |
69
|
|
|
Parameter menuName should be final. |
69
|
|
|
Method 'getMenuDisplayerMapping' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
|
Missing a Javadoc comment. |
73
|
|
|
Parameter displayerName should be final. |
73
|
|
|
Method 'initDigester' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
|
Missing a Javadoc comment. |
77
|
|
|
Line is longer than 80 characters. |
84
|
|
|
Line is longer than 80 characters. |
89
|
|
|
Line is longer than 80 characters. |
91
|
|
|
Line has trailing spaces. |
93
|
|
|
Line is longer than 80 characters. |
94
|
|
|
Line is longer than 80 characters. |
96
|
|
|
Line is longer than 80 characters. |
99
|
|
|
Line is longer than 80 characters. |
101
|
|
|
Line is longer than 80 characters. |
104
|
|
|
Line is longer than 80 characters. |
106
|
|
|
Line is longer than 80 characters. |
109
|
|
|
Line is longer than 80 characters. |
110
|
|
|
Line is longer than 80 characters. |
111
|
|
|
Line is longer than 80 characters. |
114
|
|
|
Line is longer than 80 characters. |
115
|
|
|
Line is longer than 80 characters. |
116
|
|
|
Line is longer than 80 characters. |
118
|
|
|
Line is longer than 80 characters. |
120
|
|
|
Line is longer than 80 characters. |
121
|
|
|
Method 'addMenu' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
|
Parameter menu should be final. |
130
|
|
|
Line has trailing spaces. |
131
|
|
|
Line is longer than 80 characters. |
133
|
|
|
Method 'removeMenu' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
|
Parameter name should be final. |
150
|
|
|
'name' hides a field. |
150
|
|
|
Expected @param tag for 'name'. |
150
|
|
|
First sentence should end with a period. |
154
|
|
|
Line is longer than 80 characters. |
155
|
|
|
Method 'removeAllMenus' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
|
Method 'addMenuDisplayerMapping' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
|
Missing a Javadoc comment. |
162
|
|
|
Parameter displayerMapping should be final. |
162
|
|
|
Line is longer than 80 characters. |
164
|
|
|
First sentence should end with a period. |
173
|
|
|
Method 'getDisplayers' is not designed for extension - needs to be abstract, final or empty. |
178
|
|
|
Method 'setDisplayers' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
|
Parameter displayers should be final. |
188
|
|
|
'displayers' hides a field. |
188
|
|
|
Expected @param tag for 'displayers'. |
188
|
|
|
Method 'load' is not designed for extension - needs to be abstract, final or empty. |
192
|
|
|
Missing a Javadoc comment. |
192
|
|
|
Line is longer than 80 characters. |
194
|
|
|
Line is longer than 80 characters. |
205
|
|
|
Must have at least one statement. |
209
|
|
|
Method 'reload' is not designed for extension - needs to be abstract, final or empty. |
214
|
|
|
Missing a Javadoc comment. |
214
|
|
|
Method 'setLoadParam' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
|
Missing a Javadoc comment. |
220
|
|
|
Parameter loadParam should be final. |
220
|
|
|
Method 'getLoadParam' is not designed for extension - needs to be abstract, final or empty. |
224
|
|
|
Missing a Javadoc comment. |
224
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
228
|
|
|
Missing a Javadoc comment. |
228
|
|
|
Parameter name should be final. |
228
|
|
|
'name' hides a field. |
228
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
232
|
|
|
Missing a Javadoc comment. |
232
|
|
|
Method 'getServletContext' is not designed for extension - needs to be abstract, final or empty. |
236
|
|
|
Missing a Javadoc comment. |
236
|
|
|
Method 'setServletContext' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
|
Missing a Javadoc comment. |
240
|
|
|
Parameter context should be final. |
240
|
|
|
Line is longer than 80 characters. |
245
|
|
|
Method 'getMenu' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
|
Parameter menuName should be final. |
250
|
|
|
Parameter delimiter should be final. |
250
|
|
|
'name' hides a field. |
261
|
|
|
Line is longer than 80 characters. |
263
|
|
|
Line has trailing spaces. |
283
|
|
|
Method 'getMenuDepth' is not designed for extension - needs to be abstract, final or empty. |
286
|
|
|
Parameter menuName should be final. |
286
|
|
|
'if' construct must use '{}'s. |
289
|
|
|
'if' construct must use '{}'s. |
291
|
|
|
Line is longer than 80 characters. |
298
|
|
|
Method 'getMenuDepth' is not designed for extension - needs to be abstract, final or empty. |
301
|
|
|
'if' construct must use '{}'s. |
306
|
|
|
'if' construct must use '{}'s. |
310
|
|
|
Method 'getTopMenusAsArray' is not designed for extension - needs to be abstract, final or empty. |
320
|
|
|
'menus' hides a field. |
322
|
|
|
First sentence should end with a period. |
330
|
|
|
Method 'getTopMenusNames' is not designed for extension - needs to be abstract, final or empty. |
334
|
|
|
'menus' hides a field. |
335
|
|
|
Method 'setBreadCrumbDelimiter' is not designed for extension - needs to be abstract, final or empty. |
344
|
|
|
Missing a Javadoc comment. |
344
|
|
|
Parameter string should be final. |
344
|
|
|
Method 'buildBreadCrumbs' is not designed for extension - needs to be abstract, final or empty. |
348
|
|
|
Missing a Javadoc comment. |
348
|
|
|
'menus' hides a field. |
352
|
|
|
'cast' is not followed by whitespace. |
352
|
|
|
'cast' is not followed by whitespace. |
354
|
|
|
Method 'buildBreadCrumbs' is not designed for extension - needs to be abstract, final or empty. |
359
|
|
|
Missing a Javadoc comment. |
359
|
|
|
Parameter delimiter should be final. |
359
|
net/sf/navigator/menu/PermissionsAdapter.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Line has trailing spaces. |
10
|
|
|
Line has trailing spaces. |
11
|
|
|
Line has trailing spaces. |
16
|
|
|
Redundant 'public' modifier. |
22
|
|
|
Expected @param tag for 'menu'. |
22
|
|
|
Line has trailing spaces. |
23
|
net/sf/navigator/menu/Repository.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
net/sf/navigator/menu/RolesPermissionsAdapter.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Missing a Javadoc comment. |
19
|
|
|
Missing a Javadoc comment. |
20
|
|
|
Missing a Javadoc comment. |
22
|
|
|
Parameter request should be final. |
22
|
|
|
'request' hides a field. |
22
|
|
|
Method 'isAllowed' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
|
Parameter menu should be final. |
31
|
|
|
Expected @param tag for 'menu'. |
31
|
|
|
'=' is not preceded with whitespace. |
37
|
|
|
'=' is not followed by whitespace. |
37
|
net/sf/navigator/menu/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
net/sf/navigator/taglib/DisplayMenuTag.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Missing a Javadoc comment. |
51
|
|
|
'static' modifier out of order with the JLS suggestions. |
51
|
|
|
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
51
|
|
|
Missing a Javadoc comment. |
52
|
|
|
Missing a Javadoc comment. |
53
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
|
Missing a Javadoc comment. |
56
|
|
|
Parameter name should be final. |
56
|
|
|
'name' hides a field. |
56
|
|
|
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
|
Missing a Javadoc comment. |
60
|
|
|
Parameter target should be final. |
60
|
|
|
'target' hides a field. |
60
|
|
|
Method 'doStartTag' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
|
Missing a Javadoc comment. |
64
|
|
|
Line is longer than 80 characters. |
66
|
|
|
Line is longer than 80 characters. |
74
|
|
|
Line has trailing spaces. |
98
|
|
|
Line is longer than 80 characters. |
108
|
|
|
'+' should be on a new line. |
108
|
|
|
Line is longer than 80 characters. |
139
|
|
|
Method 'setPageLocation' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
|
Parameter menu should be final. |
139
|
|
|
Expected @throws tag for 'MalformedURLException'. |
139
|
|
|
Expected @throws tag for 'JspException'. |
139
|
|
|
Line is longer than 80 characters. |
140
|
|
|
Line is longer than 80 characters. |
164
|
|
|
Line is longer than 80 characters. |
179
|
|
|
Method 'setLocation' is not designed for extension - needs to be abstract, final or empty. |
179
|
|
|
Missing a Javadoc comment. |
179
|
|
|
Parameter menu should be final. |
179
|
|
|
Line is longer than 80 characters. |
180
|
|
|
Line is longer than 80 characters. |
185
|
|
|
Line is longer than 80 characters. |
186
|
|
|
Line is longer than 80 characters. |
187
|
|
|
Line is longer than 80 characters. |
190
|
|
|
Line is longer than 80 characters. |
191
|
|
|
Line is longer than 80 characters. |
197
|
|
|
Line is longer than 80 characters. |
198
|
|
|
Line is longer than 80 characters. |
202
|
|
|
Line is longer than 80 characters. |
204
|
|
|
Expected an @return tag. |
216
|
|
|
Method 'getPage' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
|
Parameter page should be final. |
216
|
|
|
Line has trailing spaces. |
225
|
|
|
Missing a Javadoc comment. |
226
|
|
|
Parameter str should be final. |
226
|
|
|
Parameter request should be final. |
226
|
|
|
Line is longer than 80 characters. |
232
|
|
|
Line has trailing spaces. |
233
|
|
|
'+' should be on a new line. |
242
|
|
|
Method 'release' is not designed for extension - needs to be abstract, final or empty. |
253
|
|
|
Missing a Javadoc comment. |
253
|
net/sf/navigator/taglib/UseMenuDisplayerTag.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
First sentence should end with a period. |
19
|
|
|
Extra HTML tag found: </p> |
20
|
|
|
Line has trailing spaces. |
26
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Line is longer than 80 characters. |
34
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Line is longer than 80 characters. |
35
|
|
|
Missing a Javadoc comment. |
35
|
|
|
Missing a Javadoc comment. |
36
|
|
|
Missing a Javadoc comment. |
37
|
|
|
Line has trailing spaces. |
38
|
|
|
Missing a Javadoc comment. |
39
|
|
|
Variable 'messages' must be private and have accessor methods. |
39
|
|
|
Missing a Javadoc comment. |
44
|
|
|
Variable 'menuDisplayer' must be private and have accessor methods. |
44
|
|
|
Missing a Javadoc comment. |
45
|
|
|
Variable 'localeKey' must be private and have accessor methods. |
45
|
|
|
Missing a Javadoc comment. |
46
|
|
|
Variable 'name' must be private and have accessor methods. |
46
|
|
|
Missing a Javadoc comment. |
47
|
|
|
Variable 'bundleKey' must be private and have accessor methods. |
47
|
|
|
Missing a Javadoc comment. |
48
|
|
|
Variable 'id' must be private and have accessor methods. |
48
|
|
|
Missing a Javadoc comment. |
49
|
|
|
Missing a Javadoc comment. |
50
|
|
|
Missing a Javadoc comment. |
51
|
|
|
Line has trailing spaces. |
52
|
|
|
Missing a Javadoc comment. |
52
|
|
|
Variable 'rb' must be private and have accessor methods. |
52
|
|
|
Method 'getBundle' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
|
Missing a Javadoc comment. |
57
|
|
|
Method 'setBundle' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
|
Missing a Javadoc comment. |
61
|
|
|
Parameter bundle should be final. |
61
|
|
|
Method 'getConfig' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
|
Missing a Javadoc comment. |
65
|
|
|
Method 'setConfig' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
|
Missing a Javadoc comment. |
69
|
|
|
Parameter config should be final. |
69
|
|
|
'config' hides a field. |
69
|
|
|
Method 'getLocale' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
|
Missing a Javadoc comment. |
77
|
|
|
Method 'setLocale' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
|
Missing a Javadoc comment. |
81
|
|
|
Parameter locale should be final. |
81
|
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
|
Missing a Javadoc comment. |
85
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
|
Missing a Javadoc comment. |
89
|
|
|
Parameter name should be final. |
89
|
|
|
'name' hides a field. |
89
|
|
|
Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
|
Missing a Javadoc comment. |
93
|
|
|
Parameter id should be final. |
93
|
|
|
'id' hides a field. |
93
|
|
|
Method 'getRepository' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
|
Missing a Javadoc comment. |
97
|
|
|
Method 'setRepository' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
|
Parameter repository should be final. |
108
|
|
|
'repository' hides a field. |
108
|
|
|
Expected @param tag for 'repository'. |
108
|
|
|
Method 'getPermissions' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
|
Method 'setPermissions' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
|
Parameter permissions should be final. |
122
|
|
|
'permissions' hides a field. |
122
|
|
|
Method 'doStartTag' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
|
Missing a Javadoc comment. |
126
|
|
|
Line is longer than 80 characters. |
140
|
|
|
Line is longer than 80 characters. |
155
|
|
|
'permissions' hides a field. |
158
|
|
|
Line has trailing spaces. |
176
|
|
|
Line has trailing spaces. |
180
|
|
|
Line is longer than 80 characters. |
183
|
|
|
'&&' should be on a new line. |
185
|
|
|
Line has trailing spaces. |
193
|
|
|
Line is longer than 80 characters. |
194
|
|
|
Line has trailing spaces. |
202
|
|
|
Line has trailing spaces. |
207
|
|
|
Line has trailing spaces. |
217
|
|
|
Method 'getPermissionsAdapter' is not designed for extension - needs to be abstract, final or empty. |
235
|
|
|
Missing a Javadoc comment. |
235
|
|
|
Line is longer than 80 characters. |
243
|
|
|
Line is longer than 80 characters. |
249
|
|
|
Method 'doEndTag' is not designed for extension - needs to be abstract, final or empty. |
257
|
|
|
Missing a Javadoc comment. |
257
|
|
|
Method 'release' is not designed for extension - needs to be abstract, final or empty. |
264
|
|
|
Missing a Javadoc comment. |
264
|
net/sf/navigator/taglib/el/DisplayMenuTag.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Missing a Javadoc comment. |
17
|
|
|
Missing a Javadoc comment. |
18
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
20
|
|
|
Missing a Javadoc comment. |
20
|
|
|
Parameter name should be final. |
20
|
|
|
'name' hides a field. |
20
|
|
|
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. |
24
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Parameter target should be final. |
24
|
|
|
'target' hides a field. |
24
|
|
|
Missing a Javadoc comment. |
28
|
|
|
Missing a Javadoc comment. |
33
|
|
|
Method 'release' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Method 'doStartTag' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
|
Missing a Javadoc comment. |
43
|
|
|
Method 'setPageLocation' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
|
Parameter menu should be final. |
55
|
|
|
Expected @param tag for 'menu'. |
55
|
|
|
Expected @throws tag for 'MalformedURLException'. |
56
|
|
|
Expected @throws tag for 'JspException'. |
56
|
|
|
Line is longer than 80 characters. |
61
|
|
|
Missing a Javadoc comment. |
75
|
net/sf/navigator/taglib/el/ExpressionEvaluator.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Missing a Javadoc comment. |
18
|
|
|
Missing a Javadoc comment. |
19
|
|
|
Missing a Javadoc comment. |
23
|
|
|
Parameter tag should be final. |
23
|
|
|
'tag' hides a field. |
23
|
|
|
Parameter context should be final. |
23
|
|
|
'context' hides a field. |
23
|
|
|
Method 'eval' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
|
Parameter attrName should be final. |
35
|
|
|
Expected @param tag for 'attrName'. |
35
|
|
|
Parameter attrValue should be final. |
35
|
|
|
Expected @param tag for 'attrValue'. |
35
|
|
|
Parameter returnClass should be final. |
35
|
|
|
Expected @param tag for 'returnClass'. |
35
|
|
|
Expected @throws tag for 'JspException'. |
36
|
|
|
Method 'evalString' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
|
Missing a Javadoc comment. |
48
|
|
|
Parameter attrName should be final. |
48
|
|
|
Parameter attrValue should be final. |
48
|
|
|
Method 'evalBoolean' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
|
Missing a Javadoc comment. |
53
|
|
|
Parameter attrName should be final. |
53
|
|
|
Parameter attrValue should be final. |
53
|
|
|
Method 'evalLong' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
|
Missing a Javadoc comment. |
64
|
|
|
Parameter attrName should be final. |
64
|
|
|
Parameter attrValue should be final. |
64
|
|
|
Method 'evalInt' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
|
Missing a Javadoc comment. |
75
|
|
|
Parameter attrName should be final. |
75
|
|
|
Parameter attrValue should be final. |
75
|
net/sf/navigator/taglib/el/UseMenuDisplayerTag.java
| Error |
Line |
|
|
Line does not match expected header line of '/*'. |
1
|
|
|
Line is longer than 80 characters. |
18
|
|
|
Missing a Javadoc comment. |
19
|
|
|
Missing a Javadoc comment. |
20
|
|
|
Missing a Javadoc comment. |
21
|
|
|
Missing a Javadoc comment. |
22
|
|
|
Missing a Javadoc comment. |
23
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
26
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Parameter name should be final. |
26
|
|
|
'name' hides a field. |
26
|
|
|
Method 'setBundle' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Parameter bundle should be final. |
30
|
|
|
'bundle' hides a field. |
30
|
|
|
Method 'setConfig' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Parameter config should be final. |
34
|
|
|
'config' hides a field. |
34
|
|
|
Method 'setLocale' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
|
Missing a Javadoc comment. |
38
|
|
|
Parameter locale should be final. |
38
|
|
|
'locale' hides a field. |
38
|
|
|
Method 'setPermissions' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
|
Missing a Javadoc comment. |
42
|
|
|
Parameter permissions should be final. |
42
|
|
|
'permissions' hides a field. |
42
|
|
|
Method 'setRepository' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
|
Missing a Javadoc comment. |
46
|
|
|
Parameter key should be final. |
46
|
|
|
Missing a Javadoc comment. |
50
|
|
|
Missing a Javadoc comment. |
55
|
|
|
Method 'release' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
|
Missing a Javadoc comment. |
64
|
|
|
Method 'doStartTag' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
|
Missing a Javadoc comment. |
69
|
|
|
Line is longer than 80 characters. |
79
|
|
|
Missing a Javadoc comment. |
91
|
net/sf/navigator/taglib/el/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
net/sf/navigator/taglib/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
net/sf/navigator/util/LoadableResource.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Missing a Javadoc comment. |
20
|
|
|
Redundant 'public' modifier. |
20
|
|
|
Missing a Javadoc comment. |
22
|
|
|
Redundant 'public' modifier. |
22
|
|
|
Missing a Javadoc comment. |
24
|
|
|
Redundant 'public' modifier. |
24
|
|
|
Missing a Javadoc comment. |
26
|
|
|
Redundant 'public' modifier. |
26
|
|
|
Missing a Javadoc comment. |
28
|
|
|
Redundant 'public' modifier. |
28
|
|
|
Missing a Javadoc comment. |
30
|
|
|
Redundant 'public' modifier. |
30
|
|
|
Missing a Javadoc comment. |
32
|
|
|
Redundant 'public' modifier. |
32
|
|
|
Missing a Javadoc comment. |
34
|
|
|
Redundant 'public' modifier. |
34
|
net/sf/navigator/util/LoadableResourceException.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Line is longer than 80 characters. |
18
|
|
|
'{' is not followed by whitespace. |
20
|
|
|
'}' is not preceded with whitespace. |
20
|
|
|
Line is longer than 80 characters. |
23
|
|
|
Parameter msg should be final. |
26
|
net/sf/navigator/util/MessageResources.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
2
|
|
|
Line has trailing spaces. |
7
|
|
|
Line has trailing spaces. |
11
|
|
|
Line has trailing spaces. |
13
|
|
|
Variable 'log' must be private and have accessor methods. |
59
|
|
|
Variable 'config' must be private and have accessor methods. |
64
|
|
|
Method 'getConfig' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
|
Variable 'defaultLocale' must be private and have accessor methods. |
77
|
|
|
Variable 'factory' must be private and have accessor methods. |
82
|
|
|
Method 'getFactory' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
|
Variable 'formats' must be private and have accessor methods. |
96
|
|
|
Line is longer than 80 characters. |
99
|
|
|
Variable 'returnNull' must be private and have accessor methods. |
102
|
|
|
Line is longer than 80 characters. |
105
|
|
|
Method 'getReturnNull' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
|
Line is longer than 80 characters. |
114
|
|
|
Method 'setReturnNull' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
|
Parameter returnNull should be final. |
119
|
|
|
'returnNull' hides a field. |
119
|
|
|
Parameter factory should be final. |
131
|
|
|
'factory' hides a field. |
131
|
|
|
Parameter config should be final. |
131
|
|
|
'config' hides a field. |
131
|
|
|
Parameter factory should be final. |
145
|
|
|
'factory' hides a field. |
145
|
|
|
Parameter config should be final. |
146
|
|
|
'config' hides a field. |
146
|
|
|
Parameter returnNull should be final. |
147
|
|
|
'returnNull' hides a field. |
147
|
|
|
Expected an @return tag. |
163
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
|
Parameter key should be final. |
163
|
|
|
Expected an @return tag. |
176
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
|
Parameter key should be final. |
176
|
|
|
Parameter args should be final. |
176
|
|
|
Array brackets at illegal position. |
176
|
|
|
Expected an @return tag. |
189
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
189
|
|
|
Parameter key should be final. |
189
|
|
|
Parameter arg0 should be final. |
189
|
|
|
Expected an @return tag. |
203
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
203
|
|
|
Parameter key should be final. |
203
|
|
|
Parameter arg0 should be final. |
203
|
|
|
Parameter arg1 should be final. |
203
|
|
|
Expected an @return tag. |
218
|
|
|
Line is longer than 80 characters. |
218
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
|
Parameter key should be final. |
218
|
|
|
Parameter arg0 should be final. |
218
|
|
|
Parameter arg1 should be final. |
218
|
|
|
Parameter arg2 should be final. |
218
|
|
|
Expected an @return tag. |
234
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
|
Parameter key should be final. |
235
|
|
|
Parameter arg0 should be final. |
236
|
|
|
Parameter arg1 should be final. |
237
|
|
|
Parameter arg2 should be final. |
238
|
|
|
Parameter arg3 should be final. |
239
|
|
|
Expected an @return tag. |
255
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
255
|
|
|
Parameter key should be final. |
256
|
|
|
Parameter arg0 should be final. |
257
|
|
|
Parameter arg1 should be final. |
258
|
|
|
Parameter arg2 should be final. |
259
|
|
|
Parameter arg3 should be final. |
260
|
|
|
Parameter arg4 should be final. |
261
|
|
|
Line is longer than 80 characters. |
263
|
|
|
Expected an @return tag. |
279
|
|
|
Parameter locale should be final. |
279
|
|
|
Parameter key should be final. |
279
|
|
|
Expected an @return tag. |
291
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
291
|
|
|
Parameter locale should be final. |
291
|
|
|
Parameter key should be final. |
291
|
|
|
Parameter args should be final. |
291
|
|
|
Array brackets at illegal position. |
291
|
|
|
Avoid inline conditionals. |
307
|
|
|
Expected an @return tag. |
330
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
330
|
|
|
Parameter locale should be final. |
330
|
|
|
Parameter key should be final. |
330
|
|
|
Parameter arg0 should be final. |
330
|
|
|
'{' is followed by whitespace. |
331
|
|
|
Expected an @return tag. |
345
|
|
|
Line is longer than 80 characters. |
345
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
345
|
|
|
Parameter locale should be final. |
345
|
|
|
Parameter key should be final. |
345
|
|
|
Parameter arg0 should be final. |
345
|
|
|
Parameter arg1 should be final. |
345
|
|
|
'{' is followed by whitespace. |
346
|
|
|
Expected an @return tag. |
361
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
361
|
|
|
Parameter locale should be final. |
362
|
|
|
Parameter key should be final. |
363
|
|
|
Parameter arg0 should be final. |
364
|
|
|
Parameter arg1 should be final. |
365
|
|
|
Parameter arg2 should be final. |
366
|
|
|
'{' is followed by whitespace. |
368
|
|
|
Expected an @return tag. |
384
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
384
|
|
|
Parameter locale should be final. |
385
|
|
|
Parameter key should be final. |
386
|
|
|
Parameter arg0 should be final. |
387
|
|
|
Parameter arg1 should be final. |
388
|
|
|
Parameter arg2 should be final. |
389
|
|
|
Parameter arg3 should be final. |
390
|
|
|
Line is longer than 80 characters. |
392
|
|
|
'{' is followed by whitespace. |
392
|
|
|
Expected an @return tag. |
409
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
409
|
|
|
Parameter locale should be final. |
410
|
|
|
Parameter key should be final. |
411
|
|
|
Parameter arg0 should be final. |
412
|
|
|
Parameter arg1 should be final. |
413
|
|
|
Parameter arg2 should be final. |
414
|
|
|
Parameter arg3 should be final. |
415
|
|
|
Parameter arg4 should be final. |
416
|
|
|
Line is longer than 80 characters. |
418
|
|
|
'{' is followed by whitespace. |
418
|
|
|
Expected an @return tag. |
427
|
|
|
Method 'isPresent' is not designed for extension - needs to be abstract, final or empty. |
427
|
|
|
Parameter key should be final. |
427
|
|
|
Expected an @return tag. |
441
|
|
|
Method 'isPresent' is not designed for extension - needs to be abstract, final or empty. |
441
|
|
|
Parameter locale should be final. |
441
|
|
|
Parameter key should be final. |
441
|
|
|
Conditional logic can be removed. |
448
|
|
|
Expected an @return tag. |
465
|
|
|
Method 'escape' is not designed for extension - needs to be abstract, final or empty. |
465
|
|
|
Parameter string should be final. |
465
|
|
|
Expected an @return tag. |
495
|
|
|
Method 'localeKey' is not designed for extension - needs to be abstract, final or empty. |
495
|
|
|
Parameter locale should be final. |
495
|
|
|
Avoid inline conditionals. |
496
|
|
|
Expected an @return tag. |
506
|
|
|
Method 'messageKey' is not designed for extension - needs to be abstract, final or empty. |
506
|
|
|
Parameter locale should be final. |
506
|
|
|
Parameter key should be final. |
506
|
|
|
Expected an @return tag. |
519
|
|
|
Method 'messageKey' is not designed for extension - needs to be abstract, final or empty. |
519
|
|
|
Parameter localeKey should be final. |
519
|
|
|
Parameter key should be final. |
519
|
|
|
Variable 'defaultFactory' must be private and have accessor methods. |
531
|
|
|
Expected an @return tag. |
539
|
|
|
Line is longer than 80 characters. |
539
|
|
|
'static' modifier out of order with the JLS suggestions. |
539
|
|
|
Parameter config should be final. |
539
|
|
|
Method 'log' is not designed for extension - needs to be abstract, final or empty. |
553
|
|
|
Parameter message should be final. |
553
|
|
|
Method 'log' is not designed for extension - needs to be abstract, final or empty. |
564
|
|
|
Parameter message should be final. |
564
|
|
|
Parameter throwable should be final. |
564
|
net/sf/navigator/util/MessageResourcesFactory.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
2
|
|
|
Line has trailing spaces. |
7
|
|
|
Line has trailing spaces. |
11
|
|
|
Line has trailing spaces. |
13
|
|
|
Line has trailing spaces. |
19
|
|
|
Variable 'returnNull' must be private and have accessor methods. |
56
|
|
|
Line is longer than 80 characters. |
59
|
|
|
Method 'getReturnNull' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
|
Line is longer than 80 characters. |
71
|
|
|
Method 'setReturnNull' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
|
Parameter returnNull should be final. |
73
|
|
|
'returnNull' hides a field. |
73
|
|
|
Expected an @return tag. |
87
|
|
|
Parameter config should be final. |
87
|
|
|
Variable 'clazz' must be private and have accessor methods. |
97
|
|
|
Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
103
|
|
|
Variable 'factoryClass' must be private and have accessor methods. |
110
|
|
|
Parameter factoryClass should be final. |
129
|
|
|
'factoryClass' hides a field. |
129
|
|
|
Expected an @return tag. |
144
|
|
|
'if' construct must use '{}'s. |
148
|
net/sf/navigator/util/PropertyMessageResources.java
| Error |
Line |
|
|
Line does not match expected header line of ' * $Header: /cvsroot/struts-menu/navigator/LICENSE.txt,v 1.1 2003/09/24 03:01:02 mraible Exp $'. |
2
|
|
|
Line is longer than 80 characters. |
2
|
|
|
Line has trailing spaces. |
7
|
|
|
Line has trailing spaces. |
11
|
|
|
Line has trailing spaces. |
13
|
|
|
Line has trailing spaces. |
19
|
|
|
Parameter factory should be final. |
62
|
|
|
Parameter config should be final. |
63
|
|
|
Parameter factory should be final. |
79
|
|
|
Parameter config should be final. |
80
|
|
|
Parameter returnNull should be final. |
80
|
|
|
'+' should be on a new line. |
83
|
|
|
Variable 'locales' must be private and have accessor methods. |
96
|
|
|
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
102
|
|
|
Variable 'messages' must be private and have accessor methods. |
110
|
|
|
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
|
Parameter locale should be final. |
130
|
|
|
Parameter key should be final. |
130
|
|
|
Method 'loadLocale' is not designed for extension - needs to be abstract, final or empty. |
222
|
|
|
Parameter localeKey should be final. |
222
|
|
|
Line has trailing spaces. |
227
|
|
|
Line has trailing spaces. |
232
|
|
|
Line has trailing spaces. |
240
|
|
|
Line has trailing spaces. |
249
|
|
|
Line is longer than 80 characters. |
250
|
|
|
Line has trailing spaces. |
254
|
|
|
Line has trailing spaces. |
259
|
|
|
Line has trailing spaces. |
270
|
|
|
Line has trailing spaces. |
279
|
|
|
Line is longer than 80 characters. |
285
|
|
|
Line is longer than 80 characters. |
287
|
net/sf/navigator/util/PropertyMessageResourcesFactory.java
| Error |
Line |
|
|
Missing a header - not enough lines in file. |
1
|
|
|
Line is longer than 80 characters. |
2
|
|
|
Line has trailing spaces. |
7
|
|
|
Line has trailing spaces. |
11
|
|
|
Line has trailing spaces. |
13
|
|
|
Line has trailing spaces. |
19
|
|
|
Expected an @return tag. |
45
|
|
|
Method 'createResources' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
|
Parameter config should be final. |
45
|
net/sf/navigator/util/package.html
| Error |
Line |
|
|
Missing package documentation file. |
0 |
