Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Total Infos Warnings Errors
414 0 0 414

Checkstyle error summary

Error Count
Method 'display' is not designed for extension - needs to be abstract, final or empty. 9
Method 'init' is not designed for extension - needs to be abstract, final or empty. 9
Must have at least one statement. 9
Parameter mapping should be final. 9
Method 'setName' is not designed for extension - needs to be abstract, final or empty. 8
Missing package documentation file. 8
Parameter arg1 should be final. 8
Line has trailing spaces. 71
Parameter pageContext should be final. 7
'if' construct must use '{}'s. 6
'{' is followed by whitespace. 6
Method 'displayComponents' is not designed for extension - needs to be abstract, final or empty. 6
Method 'getName' is not designed for extension - needs to be abstract, final or empty. 6
Method 'getTarget' is not designed for extension - needs to be abstract, final or empty. 6
Parameter arg2 should be final. 6
'config' hides a field. 5
'{' is not followed by whitespace. 5
'}' is not preceded with whitespace. 5
Expected @throws tag for 'JspException'. 5
Method 'end' is not designed for extension - needs to be abstract, final or empty. 5
Parameter attrName should be final. 5
Parameter attrValue should be final. 5
Parameter level should be final. 5
Parameter menu should be final. 46
First sentence should end with a period. 45
',' is not followed by whitespace. 4
'target' hides a field. 4
Method 'doStartTag' is not designed for extension - needs to be abstract, final or empty. 4
Method 'getConfig' is not designed for extension - needs to be abstract, final or empty. 4
Method 'release' is not designed for extension - needs to be abstract, final or empty. 4
Method 'setConfig' is not designed for extension - needs to be abstract, final or empty. 4
Method 'setTarget' is not designed for extension - needs to be abstract, final or empty. 4
Parameter allowed should be final. 4
Parameter arg3 should be final. 4
Parameter delimiter should be final. 4
Parameter factory should be final. 4
Parameter request should be final. 4
Parameter returnNull should be final. 4
Parameter sb should be final. 4
Parameter target should be final. 4
Variable 'name' must be private and have accessor methods. 4
Expected an @return tag. 35
'4' is a magic number. 3
'menus' hides a field. 3
'permissions' hides a field. 3
'returnNull' hides a field. 3
Expected @throws tag for 'IOException'. 3
Method 'buildMenuString' is not designed for extension - needs to be abstract, final or empty. 3
Method 'getArgs' is not designed for extension - needs to be abstract, final or empty. 3
Method 'getMenuDepth' is not designed for extension - needs to be abstract, final or empty. 3
Method 'getParentName' is not designed for extension - needs to be abstract, final or empty. 3
Method 'isAllowed' is not designed for extension - needs to be abstract, final or empty. 3
Method 'setLocale' is not designed for extension - needs to be abstract, final or empty. 3
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 3
Parameter menuName should be final. 3
Parameter string should be final. 3
Variable 'log' must be private and have accessor methods. 3
Variable 'messages' must be private and have accessor methods. 3
Missing a Javadoc comment. 262
Avoid inline conditionals. 24
Redundant 'public' modifier. 24
Line contains a tab character. 237
'+' should be on a new line. 20
Parameter key should be final. 20
'10' is a magic number. 2
'5' is a magic number. 2
'6' is a magic number. 2
'7' is a magic number. 2
'8' is a magic number. 2
'9' is a magic number. 2
'=' is not followed by whitespace. 2
'=' is not preceded with whitespace. 2
'cast' is not followed by whitespace. 2
'factory' hides a field. 2
'locale' hides a field. 2
'menuConfig' hides a field. 2
'static' modifier out of order with the JLS suggestions. 2
'{' is not preceded with whitespace. 2
'}' should be on the same line. 2
Array brackets at illegal position. 2
Expected @param tag for 'context'. 2
Expected @throws tag for 'MalformedURLException'. 2
Method 'buildBreadCrumbs' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getImage' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getLocale' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getMenu' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getPage' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getPermissionsAdapter' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getReturnNull' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. 2
Method 'getType' is not designed for extension - needs to be abstract, final or empty. 2
Method 'isPresent' is not designed for extension - needs to be abstract, final or empty. 2
Method 'log' is not designed for extension - needs to be abstract, final or empty. 2
Method 'messageKey' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setBundle' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setLocation' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setMenuConfig' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setPageLocation' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setPermissions' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setRepository' is not designed for extension - needs to be abstract, final or empty. 2
Method 'setReturnNull' is not designed for extension - needs to be abstract, final or empty. 2
Parameter arg4 should be final. 2
Parameter args should be final. 2
Parameter bundle should be final. 2
Parameter localeKey should be final. 2
Parameter menuConfig should be final. 2
Parameter message should be final. 2
Parameter page should be final. 2
Parameter permissions should be final. 2
Parameter response should be final. 2
Parameter sce should be final. 2
Unused @throws tag for 'NullPointerException.'. 2
Using the '.*' form of import should be avoided - java.util.*. 2
Variable 'config' must be private and have accessor methods. 2
Variable 'returnNull' must be private and have accessor methods. 2
Variable 'target' must be private and have accessor methods. 2
Unused Javadoc tag. 19
Line is longer than 80 characters. 187
Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 15
Parameter locale should be final. 13
'3' is a magic number. 12
Parameter arg0 should be final. 12
'name' hides a field. 11
'{' should be on the previous line. 11
Parameter config should be final. 11
Parameter context should be final. 11
Parameter name should be final. 11
Expected @param tag for 'menu'. 10
')' is preceded with whitespace. 1
'*' is not followed by whitespace. 1
'*' is not preceded with whitespace. 1
'1000' is a magic number. 1
'action' hides a field. 1
'align' hides a field. 1
'altImage' hides a field. 1
'bundle' hides a field. 1
'context' hides a field. 1
'description' hides a field. 1
'displayers' hides a field. 1
'factoryClass' hides a field. 1
'forward' hides a field. 1
'height' hides a field. 1
'id' hides a field. 1
'image' hides a field. 1
'last' hides a field. 1
'location' hides a field. 1
'mapping' hides a field. 1
'menuComponents' hides a field. 1
'messages' hides a field. 1
'module' hides a field. 1
'onclick' hides a field. 1
'ondblclick' hides a field. 1
'onmouseout' hides a field. 1
'onmouseover' hides a field. 1
'page' hides a field. 1
'pageContext' hides a field. 1
'parentMenu' hides a field. 1
'permissionsAdapter' hides a field. 1
'repository' hides a field. 1
'request' hides a field. 1
'roles' hides a field. 1
'servlet' hides a field. 1
'tag' hides a field. 1
'title' hides a field. 1
'toolTip' hides a field. 1
'type' hides a field. 1
'url' hides a field. 1
'while' is not followed by whitespace. 1
'width' hides a field. 1
Conditional logic can be removed. 1
Definition of 'equals()' without corresponding definition of 'hashCode()'. 1
Expected @param tag for 'attrName'. 1
Expected @param tag for 'attrValue'. 1
Expected @param tag for 'displayers'. 1
Expected @param tag for 'form'. 1
Expected @param tag for 'height'. 1
Expected @param tag for 'name'. 1
Expected @param tag for 'repository'. 1
Expected @param tag for 'request'. 1
Expected @param tag for 'response'. 1
Expected @param tag for 'returnClass'. 1
Expected @param tag for 'sce'. 1
Expected @param tag for 'string'. 1
Expected @param tag for 'theMenuNames'. 1
Expected @param tag for 'url'. 1
Expected @throws tag for 'ServletException'. 1
Method 'addMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'addMenuComponent' is not designed for extension - needs to be abstract, final or empty. 1
Method 'addMenuDisplayerMapping' is not designed for extension - needs to be abstract, final or empty. 1
Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. 1
Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. 1
Method 'createResources' is not designed for extension - needs to be abstract, final or empty. 1
Method 'destroy' is not designed for extension - needs to be abstract, final or empty. 1
Method 'doEndTag' is not designed for extension - needs to be abstract, final or empty. 1
Method 'equals' is not designed for extension - needs to be abstract, final or empty. 1
Method 'escape' is not designed for extension - needs to be abstract, final or empty. 1
Method 'eval' is not designed for extension - needs to be abstract, final or empty. 1
Method 'evalBoolean' is not designed for extension - needs to be abstract, final or empty. 1
Method 'evalInt' is not designed for extension - needs to be abstract, final or empty. 1
Method 'evalLong' is not designed for extension - needs to be abstract, final or empty. 1
Method 'evalString' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getAction' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getAlign' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getAltImage' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getBreadCrumb' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getBundle' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getComponents' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getDisplayers' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getExtra' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getFactory' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getForward' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getLoadParam' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getLocation' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuComponents' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuConfig' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuDisplayerMapping' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuNames' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuOnClick' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuTarget' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMenuToolTip' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getMessageResources' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getModule' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getOnContextMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getOnclick' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getOndblclick' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getOnmouseout' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getOnmouseover' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getParent' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getPermissions' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getRepository' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getRoles' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getServletContext' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getSpace' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getToolTip' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getTopMenus' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getTopMenusAsArray' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getTopMenusNames' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. 1
Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. 1
Method 'initApplicationContext' is not designed for extension - needs to be abstract, final or empty. 1
Method 'initDigester' is not designed for extension - needs to be abstract, final or empty. 1
Method 'isLast' is not designed for extension - needs to be abstract, final or empty. 1
Method 'load' is not designed for extension - needs to be abstract, final or empty. 1
Method 'loadLocale' is not designed for extension - needs to be abstract, final or empty. 1
Method 'localeKey' is not designed for extension - needs to be abstract, final or empty. 1
Method 'reload' is not designed for extension - needs to be abstract, final or empty. 1
Method 'removeAllMenus' is not designed for extension - needs to be abstract, final or empty. 1
Method 'removeChildren' is not designed for extension - needs to be abstract, final or empty. 1
Method 'removeMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'render' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setAction' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setAlign' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setAltImage' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setBreadCrumb' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setBreadCrumbDelimiter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setDisplayers' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setForward' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setHeight' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setId' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setImage' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setLast' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setLoadParam' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setMenuComponents' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setMessageResources' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setModule' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setOnContextMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setOnclick' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setOndblclick' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setOnmouseout' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setOnmouseover' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setPage' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setParent' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setPermissionsAdapter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setRoles' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setServletContext' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setTitle' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setToolTip' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setType' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setUrl' is not designed for extension - needs to be abstract, final or empty. 1
Method 'setWidth' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testBuildBreadCrumbNullPointerException' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testBuildBreadCrumbPassingDelimiter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepth' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthAll' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthNoMenuName' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthNullMenuName' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthOf1' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthOf2' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuDepthOf3' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuEmptyDelimiter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuEmptyMenuName' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuInvalidDelimiter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuInvalidDelimiterParentMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuInvalidMenuName' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuNewRepository' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuNoDelimiter' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuNoMenuName' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetMenuParent' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetTopMenusAsArray' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testGetTopMenusNames' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testRemoveAllMenus' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testRemoveChildren' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testSetBreadCrumbChildMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'testSetBreadCrumbTopMenu' is not designed for extension - needs to be abstract, final or empty. 1
Method 'toString' is not designed for extension - needs to be abstract, final or empty. 1
Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1
Name '_SELF' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 1
Name '_menuComponent' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1
Name 'inputMessage' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 1
Name 'itemMessage' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 1
Name 'nbsp' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 1
Parameter action should be final. 1
Parameter align should be final. 1
Parameter altImage should be final. 1
Parameter currentDepth should be final. 1
Parameter description should be final. 1
Parameter displayerMapping should be final. 1
Parameter displayerName should be final. 1
Parameter displayers should be final. 1
Parameter factoryClass should be final. 1
Parameter form should be final. 1
Parameter forward should be final. 1
Parameter height should be final. 1
Parameter id should be final. 1
Parameter image should be final. 1
Parameter last should be final. 1
Parameter length should be final. 1
Parameter loadParam should be final. 1
Parameter location should be final. 1
Parameter menuComponent should be final. 1
Parameter menuComponents should be final. 1
Parameter messages should be final. 1
Parameter module should be final. 1
Parameter msg should be final. 1
Parameter node should be final. 1
Parameter o should be final. 1
Parameter onclick should be final. 1
Parameter ondblclick should be final. 1
Parameter onmouseout should be final. 1
Parameter onmouseover should be final. 1
Parameter parentMenu should be final. 1
Parameter permissionsAdapter should be final. 1
Parameter repository should be final. 1
Parameter returnClass should be final. 1
Parameter roles should be final. 1
Parameter servlet should be final. 1
Parameter space should be final. 1
Parameter str should be final. 1
Parameter tag should be final. 1
Parameter theMenuNames should be final. 1
Parameter throwable should be final. 1
Parameter title should be final. 1
Parameter toolTip should be final. 1
Parameter type should be final. 1
Parameter url should be final. 1
Parameter width should be final. 1
Parameter writer should be final. 1
Redundant import from the same package - net.sf.navigator.displayer.MenuDisplayerMapping. 1
Redundant import from the same package - net.sf.navigator.displayer.MessageResourcesMenuDisplayer. 1
Redundant throws: 'ApplicationContextException' is unchecked exception. 1
Unused @param tag for 'actionForm'. 1
Unused import - junit.extensions.TestSetup. 1
Unused import - org.apache.commons.lang.StringUtils. 1
Variable '_menuComponent' must be private and have accessor methods. 1
Variable 'action' must be private and have accessor methods. 1
Variable 'align' must be private and have accessor methods. 1
Variable 'altImage' must be private and have accessor methods. 1
Variable 'bundleKey' must be private and have accessor methods. 1
Variable 'clazz' must be private and have accessor methods. 1
Variable 'defaultFactory' must be private and have accessor methods. 1
Variable 'defaultLocale' must be private and have accessor methods. 1
Variable 'description' must be private and have accessor methods. 1
Variable 'displayStrings' must be private and have accessor methods. 1
Variable 'displayers' must be private and have accessor methods. 1
Variable 'factory' must be private and have accessor methods. 1
Variable 'factoryClass' must be private and have accessor methods. 1
Variable 'formats' must be private and have accessor methods. 1
Variable 'forward' must be private and have accessor methods. 1
Variable 'height' must be private and have accessor methods. 1
Variable 'id' must be private and have accessor methods. 1
Variable 'image' must be private and have accessor methods. 1
Variable 'locale' must be private and have accessor methods. 1
Variable 'localeKey' must be private and have accessor methods. 1
Variable 'locales' must be private and have accessor methods. 1
Variable 'location' must be private and have accessor methods. 1
Variable 'mapping' must be private and have accessor methods. 1
Variable 'masterMenu' must be private and have accessor methods. 1
Variable 'menuComponents' must be private and have accessor methods. 1
Variable 'menuDisplayer' must be private and have accessor methods. 1
Variable 'menus' must be private and have accessor methods. 1
Variable 'module' must be private and have accessor methods. 1
Variable 'onContextMenu' must be private and have accessor methods. 1
Variable 'onclick' must be private and have accessor methods. 1
Variable 'ondblclick' must be private and have accessor methods. 1
Variable 'onmouseout' must be private and have accessor methods. 1
Variable 'onmouseover' must be private and have accessor methods. 1
Variable 'out' must be private and have accessor methods. 1
Variable 'page' must be private and have accessor methods. 1
Variable 'parentMenu' must be private and have accessor methods. 1
Variable 'permissionsAdapter' must be private and have accessor methods. 1
Variable 'rb' must be private and have accessor methods. 1
Variable 'repository' must be private and have accessor methods. 1
Variable 'roles' must be private and have accessor methods. 1
Variable 'servletContext' must be private and have accessor methods. 1
Variable 'templates' must be private and have accessor methods. 1
Variable 'title' must be private and have accessor methods. 1
Variable 'toolTip' must be private and have accessor methods. 1
Variable 'width' must be private and have accessor methods. 1
'&&' should be on a new line. 0
Extra HTML tag found: </p> 0

Checkstyle warning summary

Error Count

Checkstyle info summary

Error Count